Re: [TLS] Last look at TLS 1.2

[Eric Rescorla <ekr@xxxxxxxxxxxxxxxxxxxx>]

OK, I've now fixed this stuff in my local copy. I propose we wait
and see if anyone else has anything by like Monday and otherwise
I'll roll -10 and we can submit to Tim. WFY?

-Ekr


At Fri, 1 Feb 2008 12:34:33 +0200,
<Pasi.Eronen@xxxxxxxxx> wrote:
> 
> Three nits from my personal review:
> 
> Section 4.7: the example at the end of section isn't any more 
> fully correct with the changed definition of digitally-signed 
> (since the "digitally-signed" construct now includes the hashing 
> step). Suggested rephrasing:

Well, you could double hash, but i take your point.


>    In the following example
> 
>       stream-ciphered struct {
>           uint8 field1;
>           uint8 field2;
>           digitally-signed struct { 
>              opaque field3<0..255>;
>              uint16 field4;
>           };
>       } UserType;
> 
>    the contents of the inner struct (field3 and field4) are used 
>    as input for the signature/hash algorithm, and then the entire
>    structure is encrypted with a stream cipher. [...]
> 
> 
> 7.4.3/A.4.2, ServerKeyExchange definition: the second "case dhe_dss"
> should be "case dh_dss".

Fixed.


> 7.4.3 and A.4.2, KeyExchangeAlgorithm lists dh_anon twice

Doh! I added those cause I thought I had missed them and
my eyes have gone numb.


> Also couple of typos (could be fixed later, too):
> 
> 7.4.3/A.4.2: extra blank lines in definition of ServerKeyExchange.

You mean:

    };

} ServerKeyExchange;

Fixed.


> A.4.2: should delete descriptions of dh_p/dh_g/dh_Ys, since
>   the appendix is supposed to contain only the struct definitions

Agreed. I'm finding it a real pain to keep these harmonized.
Next time I do one of these I'm going to have some auto-appendicizer :)

> 7.4.7/A.4.3, weird indentation (and extra blank lines) in definition
>   of ClientKeyExchange.
The extra blank line was intentional for readability, but now that
you seay it, sure.


> 4.6.1, the example struct has weird indentation around the 
>   orange/banana cases.
These are fixed.

> 4.7, "pplus" -> "plus"
> 7.4.7.1, "premaster_secert" -> "premaster_secret"
> References: [IDEA] is not cited anywhere, can be removed 

Fixed.
_______________________________________________
TLS mailing list
TLS@xxxxxxxx
http://www.ietf.org/mailman/listinfo/tls