[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Some statements whose value is ignored in SRL



I've been compiling CML with -Wall, just to see what messages come
out.

There are some lines of the form

      *ptr++;

For example in, SRL_Mgr.c, but they look fine: they look as though
they're supposed to be just ptr++:

		// If this character matches one of the delimiters, then break out of
		// the loop
		if (*pDelim != '\0')
			break;
		*end ++;
		len++;
	}
	*end++;
	return end;

There's one in SRL_ldap.c (line 2401) that looks like it may be a bug:

   if( (tagId1 == EOC_TAG_ID) && (elmtLen1 == INDEFINITE_LEN))
   {
      if(*asndata++ == 0)
      {
         *decodedLen++;   /* read one byte above */
         return(SRL_SUCCESS); /* got EOC so can exit this SET OF/SEQ OF's for loop*/
      }
      else

That one's intended to be (*decodedLen)++, or ++*decodedLen, isn't it?